[examples]: Updated router-sample #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
reviewed
Feb 11, 2025
Collaborator
karthik2804
left a comment
karthik2804
left a comment
There was a problem hiding this comment.
overall LGTM- I think we should probably update the readme with the curl commands to make the usage clear.
Signed-off-by: Thorsten Hans <[email protected]>
Signed-off-by: Thorsten Hans <[email protected]>
ThorstenHans
force-pushed
the
feat/router-sample
branch
from
1ef22fa to
676053f
Compare
Contributor
Author
|
@karthik2804 I rebased the PR and updated the README for the router sample 👀 |
karthik2804
approved these changes
Feb 17, 2025
Collaborator
karthik2804
left a comment
karthik2804
left a comment
There was a problem hiding this comment.
LGTM - one comment which is not a blocker
Signed-off-by: Thorsten Hans <[email protected]>
radu-matei
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the router sample to illustrate how users could define different types of handlers. Also, a
POSTendpoint is registered for demonstration purposes.